[Bug 199154] Review Request: Slony-1 (postgresql-slony-engine)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=199154


rob <rob.myers@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rob.myers@xxxxxxxxxxxxxxx




--- Comment #56 from rob <rob.myers@xxxxxxxxxxxxxxx>  2009-08-25 18:15:38 EDT ---
What is the status on this?

I took a shot at bringing the 2.0.2-1 package up to Fedora standards:
http://rmyers.fedorapeople.org/postgresql-slony-engine/postgresql-slony-engine-2.0.2-1.1.fc11.src.rpm
http://rmyers.fedorapeople.org/postgresql-slony-engine/postgresql-slony-engine-2.0.2-1.1.fc11/postgresql-slony-engine.spec

Here is the rpmlint output:
postgresql-slony-engine.src: W: strange-permission filter-requires-perl-Pg.sh
0755

- How do I do the equivalent of %define __perl_requires %{SOURCE2} without this
being executable?

postgresql-slony-engine.x86_64: W: log-files-without-logrotate /var/log/slony1

- I wasn't sure if it was safe to rotate the files in this directory, so I left
this out for now.

postgresql-slony-engine.x86_64: W: incoherent-subsys /etc/rc.d/init.d/slony1
${NAME}

- This appears to be a false positive/limitation of rpmlint.

postgresql-slony-engine.x86_64: W: incoherent-init-script-name slony1
('postgresql-slony-engine', 'postgresql-slony-engined')

- This could easily be changed to match, if that is desirable.

Here is the scratch build in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1633604

This package has not been tested.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]