Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518849 --- Comment #3 from Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> 2009-08-25 02:42:20 EDT --- Yap; your request to join packager gets approved when your sponsor signs off on your first package (in this case, this one). Reviewing using this Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1631426 MUST • rpmlint: source: clean main package: clean -doc subpackage: 1 warning You'd want to remove _build/html/.buildinfo within the %install section. Examples are also rather large, and non-essential to using the main package, so they should go into -doc as well. Also, since the documentation is already pre-built (so you don't need to BR: on python-sphinx and build it yourself), you really only want the content of _build/html. Thus %doc docs/_build/html examples and then you can update %description doc -- currently it's even shorter than the summary! You can say, for example, (optionally copy the first paragraph of the main package's %description here) This package contains documentation and examples for %{name}. • package name: OK • spec file name: OK • package guideline-compliant: OK • license complies with guidelines: OK • license field accurate: OK • license file not deleted: OK • spec in US English: OK • spec legible: OK • source matches upstream: OK 620955f34b8424c92674fe76d5c47679 Werkzeug-0.5.1.zip 620955f34b8424c92674fe76d5c47679 ../SOURCES/Werkzeug-0.5.1.zip • builds under >= 1 archs, others excluded: OK (noarch, Koji) • build dependencies complete: OK • own all directories: OK • no dupes in %files: OK • permission: OK • %clean RPM_BUILD_ROOT: OK • macros used consistently: OK • Package contains code: OK • large docs => -doc: Almost (see above) • doc not runtime dependent: OK • clean buildroot before install: OK • filenames UTF-8: OK SHOULD • package build in mock on all architectures: OK (noarch, Koji) • package functioned as described: not tested • scriplets are sane: OK • other subpackages should require versioned base: OK • require package not files: OK One more minor change and I'll approve this and the packager request. Cheers, -- Michel -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review