Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dx - Open source version of IBM's Visualization Data Explorer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203662 ------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx 2006-09-16 19:05 EST ------- Review: builds fine in mock, rpmlint doesn't like the packages but on this occasion, the errors can be ignored Software installs and works Good consistent use of macros in US-English, UTF-8 License valid upstream and source tarballs have same md5 correct use of dist uses smp_mflags contains docs contains clean no ownership problems devel package doesn't need pkgconfig no dupes in the rpms Needs work %configure \ --disable-static \ --enable-shared \ --with-jni-path=%{java_home}/include \ --without-javadx \ --disable-dependency-tracking \ --enable-smp-linux \ --enable-new-keylayout \ --with-rsh=%{_bindir}/ssh \ Trailing \ on the end should not be there. If you remove this, I'm happy to approve the package as is. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review