Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513892 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |martin.gieseking@xxxxxx Flag| |fedora-review? --- Comment #4 from Martin Gieseking <martin.gieseking@xxxxxx> 2009-08-24 08:48:15 EDT --- Here is the full review of your package. There are just a few issues to be fixed (see below). rpmlint /var/lib/mock/fedora-11-i386/result/*.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. --------------------------------- keys used in following checklist: [+] OK [.] OK, not applicable [X] needs work --------------------------------- MUST: rpmlint must be run on every package. The output should be posted in the review. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. [X] MUST: The License field in the package spec file must match the actual license. - please update the License field to "GPLv3+ and LGPLv2+" [X] MUST: Files containing license texts must be added to %doc. - you should also include bilbokblog/COPYING containing the L(ibrary)GPL license text (rename it to COPYING.LGPL) [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources in the SRPM must match the upstream source. - md5 hash is 396da4f5fc1d91d692eefaf8e9871795 [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile,... [+] MUST: All build dependencies must be listed in BuildRequires. [+] MUST: The spec file MUST handle locales properly. [+] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [.] MUST: If the package is designed to be relocatable,... - package not relocatable [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files [+] MUST: Permissions on files must be set properly. [+] MUST: %clean section must contain rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. - no large docs [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. - no header files packaged [.] MUST: Static libraries must be in a -static package. [.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' [.] MUST: .so (without suffix) must go in a -devel package. - no .so files/symlinks without suffixes packaged [.] MUST: devel packages must require the base package using a fully versioned dependency - no devel package [+] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [X] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. - in the %install section, you should check the .desktop file integrity with desktop-file-validate (see https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files) [+] MUST: Packages must not own files/dirs already owned by other packages. [+] MUST: %install MUST start with run rm -rf %{buildroot} [+] MUST: All filenames in rpm packages must be valid UTF-8. [+] SHOULD: The reviewer should test that the package builds in mock. - builds in mock [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. - builds in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=1628570 [+] SHOULD: The reviewer should test that the package functions as described. - application seems to work properly [X] SHOULD: If scriptlets are used, those scriptlets must be sane. - used scriptlets are required and sane - you have to update the icon cache using gtk-update-icon-cache (see https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review