Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kadu-theme - themes for Kadu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206761 ------- Additional Comments From mr.ecik@xxxxxxxxx 2006-09-16 16:48 EST ------- (In reply to comment #2) > 1. package meets naming and packaging guidelines, but the origin of the > version number isn't clear, please explain. Previously, themes was included into main package and they have to get bigger version release (for example, in repo is available kadu-theme-crystal22-0.5.0-20060808svn) > 2. specfile is properly named, is cleanly written but doesn't use macros > consistently: > %define _themesdir /usr/share/kadu/themes > You should use %{_datadir} here. And since you never seem to use %{_themesdir} > without /icons, why not > %define _kaduiconsdir %{_datadir}/kadu/themes/icons ? %{_datadir} issue is fixed. I don't use kaduiconsdir macro, because I assume that there will be another themes than only icons, in future. > 5. can't verify if license field matches the actual license. > * Crystal theme is - according to README - based on Crystal SVG icons from > everaldo.com, but I can't find any license info there except: > http://www.everaldo.com/legal.html , which is definitely NOT open-source > compatible. It's used in KDE though, so I imagine this is open-source licensed, I have noticed legal section on www.evaraldo.com is not open-source compatible, but the actual icons license I found here: http://commons.wikimedia.org/wiki/Image:Crystal_Clear_action_1downarrow.png > * Glass theme has NO license information inside the tarballs Glass license is written down here: http://www.kadu.net/forum/viewtopic.php?t=6815&highlight=glass > * Nuvola theme is LGPL according to Copyright, but full license text is NOT > included (and at least that Copyright file should be in %files) I have included all licenses in %doc. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review
