Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516343 --- Comment #12 from D Haley <mycae@xxxxxxxxx> 2009-08-22 07:32:53 EDT --- Your uploaded spec and SRPM do not appear to match. Please do not modify the uploaded spec without posting a matching SRPM. Please repost an updated SRPM with the changes suggested by Guido (Comment 11). Also I don't think you need Requires: jpackage-utils in the javadoc package, as it depends on the main, which also requires jpackage-utils. > Read upsteam homepage for license information Upstream says "The code is protected by copyright, though only to avoid people selling it unmodified or copyrighting it themselves." Which is not quite PD, but close. Someone else may need to confirm the licencing here. All the source headers appear to be in place. $ diff -uh metadata-extractor.spec metadata-extractor.spec-orig --- metadata-extractor.spec 2009-08-11 04:58:42.000000000 +1000 +++ metadata-extractor.spec-orig 2009-08-22 21:32:37.000000000 +1000 @@ -11,15 +11,13 @@ # Patch provided by Gabriel Ebner to remove all references to the # com.sun classes. Package builds with a free java implementation now. Patch0: %{name}-2.3.1-nosun.patch -# Patch provided by Guido Grazioli to make junit tests complete successfully -Patch1: %{name}-2.3.1-buildxml.patch BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildArch: noarch BuildRequires: jpackage-utils BuildRequires: java-devel BuildRequires: ant -BuildRequires: ant-junit +BuildRequires: junit Requires: jpackage-utils Requires: java @@ -44,7 +42,6 @@ %prep %setup -q -c %patch0 -p1 -%patch1 -p0 # Remove pre-built JAR and class files find -name '*.jar' -exec rm -f '{}' \; @@ -56,6 +53,9 @@ # Fix end-of-line encoding sed -i 's/\r//' ChangeLog.txt +# Do not execute unit test +sed -i 's:clean, compile, test:clean, compile:' build.xml + %build ant dist-binaries javadoc @@ -96,9 +96,8 @@ %changelog -* Mon Aug 10 2009 Andrea Musuruane <musuruan@xxxxxxxxx> 2.3.1-2 +* Sun Aug 09 2009 Andrea Musuruane <musuruan@xxxxxxxxx> 2.3.1-2 - Created JAR alias -- Added a patch to make junit tests complete successfully * Sun Aug 02 2009 Andrea Musuruane <musuruan@xxxxxxxxx> 2.3.1-1 - First release -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review