Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518082 --- Comment #5 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-08-21 11:35:27 EDT --- For -2: * Requires - Still some Requires are missing: https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines * "Requires: ruby(abi) = 1.8" is missing. * Also, for consistency I usually suggest to add "BuildRequires: ruby(abi) = 1.8". * About the following line: ---------------------------------------------------------- %{__mkdir_p} %{buildroot}%{_libdir} ---------------------------------------------------------- - Perhaps "%{_mkdir_p} %{buildroot}%{gemdir}" is correct. * Directory ownership issue - Still directory ownership issue is not correctly handled. ! If you try # rpm -ivv rubygem-facade-1.0.4-2.fc12.noarch.rpm, it will show: ---------------------------------------------------------- D: /usr/lib/ruby/gems/1.8/doc/facade-1.0.4 directory created with perms 0755, no context. D: /usr/lib/ruby/gems/1.8/gems/facade-1.0.4 directory created with perms 0755, no context. D: /usr/lib/ruby/gems/1.8/gems/facade-1.0.4/lib directory created with perms 0755, no context. D: /usr/lib/ruby/gems/1.8/gems/facade-1.0.4/test directory created with perms 0755, no context. ---------------------------------------------------------- Then for example: ---------------------------------------------------------- [tasaka1@localhost ~]$ rpm -qf /usr/lib/ruby/gems/1.8/gems/facade-1.0.4/README rubygem-facade-1.0.4-2.fc12.noarch [tasaka1@localhost ~]$ rpm -qf /usr/lib/ruby/gems/1.8/gems/facade-1.0.4/ file /usr/lib/ruby/gems/1.8/gems/facade-1.0.4 is not owned by any package ---------------------------------------------------------- i.e. rubygem-facade binary rpm creates the directory %geminstdir to install "README" under there, however %geminstdir itself is not correctly owned by rubygem-facade, which is wrong. Again please check https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging:UnownedDirectories especially: https://fedoraproject.org/wiki/Packaging:UnownedDirectories#Common_Mistakes and modify the %files entry. ! Especially: For example ------------------------------------------------------------ %files %{geminstdir}/lib/ ------------------------------------------------------------ contains the directory %geminstdir/lib and all files/directories/etc under %{geminstdir}/lib. ! When fixing %files entry, please also check the section https://fedoraproject.org/wiki/Packaging/Guidelines#Duplicate_Files By the way I will appreciate it if you post the full URL of your srpm/spec on this bugzilla when you upload the new ones so that we can find them easily. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review