Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518486 --- Comment #2 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2009-08-21 08:20:26 EDT --- (In reply to comment #1) > OK naming, licensing > OK files > OK macros > OK clean, sections > ? can we get a better URL I can't find any better URL > ? should it depend upon eclipse >= 3.5? Yes, fixed. > ? do we need to symlink to the JUnit bundles in the installation? They will be resolved from the eclipse-jdt (added as requires). > X please version the tarball and its contents Done > X we need an R3_5 tag passed to the fetch script. otherwise, ... Done > OK source (md5sum doesn't match, but contents do) > > X rpmlint is not clean: > > $ rpmlint eclipse-testframework-3.5.0-1.fc11.noarch.rpm > eclipse-testframework.noarch: E: non-standard-dir-perm > /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130 > 0775 > eclipse-testframework.noarch: E: non-standard-dir-perm > /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src/org.eclipse.test.performance_3.5.0.200908201130 > 0775 > eclipse-testframework.noarch: W: spurious-executable-perm > /usr/share/doc/eclipse-testframework-3.5.0/license.html > eclipse-testframework.noarch: E: non-standard-dir-perm > /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/META-INF > 0775 > eclipse-testframework.noarch: E: non-standard-dir-perm > /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test_3.2.0/META-INF > 0775 > eclipse-testframework.noarch: W: dangling-relative-symlink > /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.easymock_2.4.0.v20090202-0900.jar > ../../../../../java/easymock2.jar > eclipse-testframework.noarch: E: non-standard-dir-perm > /usr/share/eclipse/dropins/testframework/eclipse/features/org.eclipse.test_3.5.0.200908201130 > 0775 > eclipse-testframework.noarch: E: non-standard-dir-perm > /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src > 0775 > eclipse-testframework.noarch: E: non-standard-dir-perm > /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test_3.2.0 > 0775 > eclipse-testframework.noarch: E: non-standard-dir-perm > /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src/org.eclipse.test_3.2.0 > 0775 > eclipse-testframework.noarch: W: spurious-executable-perm > /usr/share/doc/eclipse-testframework-3.5.0/epl-v10.html > 1 packages and 0 specfiles checked; 8 errors, 3 warnings. Done. I wasn't seeing all the errors you listed. But the only rpmlint warning i see is dangling-relative-symlink which is normal. New sources: Spec URL: http://akurtakov.fedorapeople.org/eclipse-testframework.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-testframework-3.5.0-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review