[Bug 206693] Review Request: KTechlab - Development and simulation of microcontrollers and electronic circuits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: KTechlab - Development and simulation of microcontrollers and electronic circuits


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206693





------- Additional Comments From rc040203@xxxxxxxxxx  2006-09-16 01:41 EST -------
Some remarks:

1. I don't understand, why you
- BR: autoconf
It's not required. Building the package invokes autoheader due to a bug
somewhere in the source tarball, nevertheless this invocation of autoheader does
nothing.

- BR: libtool
No idea why you do this.

- R: gpsim
The package doesn't directly depend on gpsim. It depends on the libs from gpsim,
which are automatically being pulled in by rpm.

- R: gputils
I don't see any dependency on this package.


2. The tarball is mal-packaged.
It ships an autom4te.cache/.

I'd suggest to rm -rf autom4te.cache in %prep.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]