Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518205 --- Comment #9 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2009-08-20 07:41:49 EDT --- A few issues: - rpmlint output: directory-naming.noarch: W: non-standard-group Development/Libraries/Java directory-naming.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/directory-naming-0.8/LICENSE.txt directory-naming.noarch: W: non-conffile-in-etc /etc/maven/fragments/directory-naming FIXED except non-conffile-in-etc - javadoc issues for naming-factory: [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/BeanFactory.java:64: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/MailSessionFactory.java:59: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator [javadoc] /notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/SendMailFactory.java:81: warning - Tag @link: reference not found: org.apache.naming.config.XmlConfigurator FIXED. I don't see this warnings. - there's a minor (a date in a comment) difference between the source that I generate and the one in the SRPM I think this is acceptable. - I'd like to see a comment for the patch to the project files FIXED. Removed. It was for maven1 build which we do not support. - I removed the remaining sed lines for "setproxy" and the build was fine. I think they can be removed. FIXED. Removed. New sources: Spec: http://akurtakov.fedorapeople.org/directory-naming.spec Srpm: http://akurtakov.fedorapeople.org/directory-naming-0.8-6.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review