Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513452 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tcallawa@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flag| |fedora-review+ --- Comment #6 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2009-08-19 13:44:20 EDT --- Two items of note: 1. Instead of using sed to try to stop configure from running twice (it doesn't work), do this: # run autogen.sh until we have a proper release, but don't run configure twice. NOCONFIGURE=true ./autogen.sh That works because the provided autogen.sh just calls out to gnome-autogen.sh, which has some intelligence. 2. Do you want to pass --enable-scaled-background to configure? == Review == Good: - rpmlint checks return: mutter-moblin.x86_64: W: shared-lib-calls-exit /usr/lib64/libmoblin-panel.so.0.0.0 exit@xxxxxxxxxxx mutter-moblin-devel.x86_64: W: no-documentation mutter-moblin-devel.x86_64: W: dangling-relative-symlink /usr/lib64/mutter/plugins/moblin-netbook.so moblin-netbook.so.3400.0.0 All safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (c781f9a6558167658fc7891d1ba8c041db1a75113ef220441c05f11a877436ed) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - locales handled properly - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Address the first two issues before commit, but this is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review