Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ssss - Shamir's secret sharing scheme https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206494 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-09-15 20:03 EST ------- I understand why you can't use the makefile, but I don't understand "$RPM_OPT_FLAGS/%{optflags}" on the gcc command line. Surely you only need the "$RPM_OPT_FLAGS" bit. This is really the only blocker I see, so I'll go ahead and approve and you can fix it when you check in. Review: * source files match upstream: 24227252aa195a146d09de1df10357a1 ssss-0.5.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. ? build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: ssss = 0.5-1.fc6 = libgmp.so.3()(64bit) * %check is not present; no test suite upstream. * no shared libraries are added to the regular linker search paths. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. APPROVED, just fix the gcc command line. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review