Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516114 Paul Howarth <paul@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |paul@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Paul Howarth <paul@xxxxxxxxxxxx> 2009-08-19 11:36:55 EDT --- I'll review this one since I had a look at an earlier submission (Bug #494219) and when the submitter of that one lost interest I had a go at packaging it myself (Bug #518046). There may be some mileage in merging our efforts actually. First looks: * shouldn't the tarball name have _r5836 rather than _r0? * is the git-core dependency a remnant of starting with the spec file for the git plugin, or is there some actual reason for having it? * the package description could list a few extra features such as allowing users to change their passwords * the setuptools regression mentioned in the comments has been fixed in F-11 so that comment could be removed * there is a patch available in svn trunk for http://trac-hacks.org/ticket/4125 (it's in my package from Bug #518046). * please include sessionstore_convert.py script (see http://www.mailinglistarchive.com/trac-users@xxxxxxxxxxxxxxxx/msg03696.html) * it's safe to use --skip-build as EPEL-4 doesn't have trac >= 0.11 so there's not likely to be an EL-4 branch of this package * the noarch/sitelib comment from the python spec file template can be dropped I think -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review