Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517821 Caolan McNamara <caolanm@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #1 from Caolan McNamara <caolanm@xxxxxxxxxx> 2009-08-19 03:31:15 EDT --- Review: + package builds in mock + rpmlint is error-free for SRPM and for RPM. + source files match upstream url + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application APPROVED. Are these hyphenation rules good for Bengali as written in Bangladesh ?, I'd guess that they probably are, if so then maybe... pushd $RPM_BUILD_ROOT/%{_datadir}/hyphen/ bn_IN_aliases="bn_BD" for lang in $bn_IN_aliases; do ln -s hyph_bn_IN.dic hyph_$lang.dic done popd after the cp is indicated -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review