Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gg2 - GNU Gadu 2 - free talking https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205136 ------- Additional Comments From mr.ecik@xxxxxxxxx 2006-09-15 12:44 EST ------- MUST items: * rpmlint output: W: gg2 mixed-use-of-spaces-and-tabs W: gg2 doc-file-dependency /usr/share/doc/gg2-2.2.9/gg2sms /usr/bin/perl W: gg2 doc-file-dependency /usr/share/doc/gg2-2.2.9/mkgg2snap /bin/sh W: gg2 doc-file-dependency /usr/share/doc/gg2-2.2.9/plugin_example/build.sh / bin/sh W: gg2-arts no-documentation W: gg2-devel no-documentation W: gg2-dockapp no-documentation W: gg2-esound no-documentation W: gg2-gadu-gadu no-documentation W: gg2-jabber no-documentation W: gg2-systray no-documentation W: gg2-tlen no-documentation W: gg2-xosd no-documentation * package is named well * spec file is named well * package meets Packaging Guidelines * package is licensed with an GPL open-source compatible license * License field matches actual license * license is included in %doc * spec is legible * md5sums are matching (e12c2153993dbbf66f8cefa3c628e7cd) * package succesfully compiles on x86_64 * BRs are listed properly * spec handles locales properly * proper %post and %postun sections * not relocatable * package owns its directories * no duplicates in %files * every %files section includes %defattr * proper %clean section * no need to doc subpackage * .pc files and headers are in -devel * .la file in -devel THINGS to do: * cosmetics: fix warning with mixed-spaces-and-tabs in spec * remove unnecessary dependiences (caused by %doc files) by adding following lines to %prep: chmod -x contrib/gg2sms chmod -x contrib/mkgg2snap chmod -x contrib/plugin_example/build.sh * you probably should remove libgg2_core.la from -devel subpackage Fix things mentioned above, and I'll approve this package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review