Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476829 --- Comment #8 from Dan Horák <dan@xxxxxxxx> 2009-08-17 07:01:14 EDT --- I am back in work from vacations, so the review continues. I have still found few issues: - you should have the license as "GPLv2+ and MIT" for the ppd subpackage because at least PPDs for Brother, OKI and SHARP are licensed under GPLv2+ - add the COPYING file from foomatic-db-20090702 as %doc for the main package - the question is who should own the /usr/share/foomatic/db/sources directory, because when only the "ppds" subpackage is installed then this dir (and all "upper dirs") will be unowned. If the "ppds" subpackage can be installed independently then creating "foomatic-db-filesystem" subpackage (containing the empty /usr/share/foomatic/db structure) looks like an option to me. The rest looks good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review