Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx --- Comment #1 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-08-17 05:54:38 EDT --- (In reply to comment #0) > Spec URL: http://red.fedorapeople.org/SRPMS/PyPE.spec > SRPM URL: http://red.fedorapeople.org/SRPMS/PyPE-2.8.8-1.fc11.src.rpm > Description: > PyPE (Python Programmers' Editor) was written in order to offer a > lightweight but powerful editor for those of you who think emacs is too > much and idle is too little. Syntax highlighting is included out of the > box, as is multiple open documents via tabs. > > $ rpmlint SPECS/PyPE* SRPMS/PyPE* RPMS/noarch/PyPE* > PyPE.noarch: E: non-executable-script > /usr/lib/python2.6/site-packages/PyPE/plugins/parsers.py 0644 /usr/bin/python > 2 packages and 1 specfiles checked; 1 errors, 0 warnings > > Not sure what to do about this error - should I make the script executable or > remove the shebang line? I'm pretty sure that script is not executed > stand-alone. Remove the shebang, Python libraries don't need it. > By the way, this is my first python-package and I hope I did everything right > :) A few things to correct: - Use the safer, time stamp keeping versions of the conversion tricks from http://fedoraproject.org/wiki/PackagingTricks#Convert_encoding_to_UTF-8 and http://fedoraproject.org/wiki/PackagingTricks#Remove_DOS_line_endings - Don't install manually - use setup.py to do the install. Have a look at the sample python spec $ rpmdev-newspec python - You need to own %{python_sitelib}/%{name}/ not %{python_sitelib}/%{name}/* -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review