Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517466 Ed Brand <edbrand@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edbrand@xxxxxxxxxxxx --- Comment #4 from Ed Brand <edbrand@xxxxxxxxxxxx> 2009-08-15 14:43:30 EDT --- The output of rpmlint looks clean. Giving your spec file a once over I see this: Use %global instead of %define, unless you really need only locally defined submacros within other macro definitions (a very rare case) See: https://fedoraproject.org/wiki/PackagingGuidelines#.25global_preferred_over_.25define -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review