Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515034 Bob Relyea <rrelyea@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(emaldona@xxxxxxxx | |om) --- Comment #19 from Bob Relyea <rrelyea@xxxxxxxxxx> 2009-08-14 17:25:26 EDT --- RPMLINT: rpmlint nss-softokn.spec nss-softokn.spec:171: W: rpm-buildroot-usage %build $RPM_BUILD_ROOT/%{unsupported_tools_directory}/shlibsign -i $RPM_BUILD_ROOT/%{_lib}/libsoftokn3.so \ nss-softokn.spec:172: W: rpm-buildroot-usage %build $RPM_BUILD_ROOT/%{unsupported_tools_directory}/shlibsign -i $RPM_BUILD_ROOT/%{_lib}/libfreebl3.so \ 0 packages and 1 specfiles checked; 0 errors, 2 warnings. NEEDSWORK: Some minor issues... 1. Remove the .test.1 from the version string. For test builds, you can use ~/.rpmmacros to set dist to your own test string (f12.elio.test for instance). 2. in the comment on getting the source you describe cvs nss-util, I think you mean cvs co nss-util. Also the directory name can be confused with the nss-util package perhaps the name nss-package-tools would be better. 3. A comment that the 'special install-post command actually gets executed as the last stip in the %install (so that the code operates on the stripped libraries). Also, I believe the %define needs to be a %global. bob -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review