Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517520 Andrew Overholt <overholt@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |overholt@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |overholt@xxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Andrew Overholt <overholt@xxxxxxxxxx> 2009-08-14 12:17:10 EDT --- Thanks for the submission. Everything looks pretty good. See comments below. - it would be nice to use %{buildroot} instead of $RPM_BUILD_ROOT but it's not a blocker - my generated source tarball has a different md5sum but the contents are the same (likely timestamp differences) - will we build with maven once it's updated? - other than the non-conffile-in-etc for the maven pom, everything is rpmlint clean - what provides %add_to_maven_depmap? I don't see it doing much in my log. Do we need a BR on maven? - please provide a link to the origin of the OSGi manifest It builds fine locally for me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review