Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507106 --- Comment #7 from Steve Whitehouse <swhiteho@xxxxxxxxxx> 2009-08-14 05:29:32 EDT --- Package review SHOULD items: License in upstream source: As above, that should be requested to be added Translations of description & summary: No translations available - can we get those via Transifex I wonder? Not sure how we can arrange that for the spec file itself. Mock build: Robert, have you already tried that? If so I'll take your word for it that it works. Package functions: It is impossible to test all package functions without a huge test suite. I can see that the code looks sane and the only reason for non-functioning would be a broken compiler which is not an issue relating to this particular package. I have used certain functions from this library before and they have worked as expected. Scriptlets: N/A Subpackages: N/A .pc files: N/A File deps outside of certain directories: N/A So I think we are most of the way there with this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review