Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516869 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-08-14 02:34:21 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1604641 - rpmlint is NOT silent for RPM. perl-Search-Xapian.i686: E: explicit-lib-dependency xapian-core-libs You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. == > Ok perl-Search-Xapian.i686: W: incoherent-version-in-changelog 1.0.11-4 ['1.0.11.0-4.fc12', '1.0.11.0-4'] The last entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. ==> Fix this + source files match upstream url 480fd99617975c1aaf9127cd7c7166bc05d07eb1 Search-Xapian-1.0.11.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=15, Tests=445, 2 wallclock secs ( 0.11 usr 0.01 sys + 0.68 cusr 0.11 csys = 0.91 CPU) + Package perl-Search-Xapian-1.0.11.0-4.fc12.i686 => Provides: Xapian.so perl(Search::Xapian) = 1.0.11.0 perl(Search::Xapian::BM25Weight) perl(Search::Xapian::BoolWeight) perl(Search::Xapian::Database) perl(Search::Xapian::Document) perl(Search::Xapian::ESet) perl(Search::Xapian::ESetIterator) perl(Search::Xapian::Enquire) perl(Search::Xapian::MSet) perl(Search::Xapian::MSet::Tied) perl(Search::Xapian::MSetIterator) perl(Search::Xapian::MultiValueSorter) perl(Search::Xapian::PerlStopper) perl(Search::Xapian::PositionIterator) perl(Search::Xapian::PostingIterator) perl(Search::Xapian::Query) perl(Search::Xapian::QueryParser) perl(Search::Xapian::RSet) perl(Search::Xapian::SimpleStopper) perl(Search::Xapian::Stem) perl(Search::Xapian::Stopper) perl(Search::Xapian::TermGenerator) perl(Search::Xapian::TermIterator) perl(Search::Xapian::TradWeight) perl(Search::Xapian::ValueIterator) perl(Search::Xapian::Weight) perl(Search::Xapian::WritableDatabase) Requires: libc.so.6 libc.so.6(GLIBC_2.1.3) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) libxapian.so.15 perl >= 0:5.006 perl(Carp) perl(DynaLoader) perl(Exporter) perl(Search::Xapian::BM25Weight) perl(Search::Xapian::BoolWeight) perl(Search::Xapian::Database) perl(Search::Xapian::Document) perl(Search::Xapian::ESet) perl(Search::Xapian::ESetIterator) perl(Search::Xapian::Enquire) perl(Search::Xapian::MSet) perl(Search::Xapian::MSet::Tied) perl(Search::Xapian::MSetIterator) perl(Search::Xapian::MultiValueSorter) perl(Search::Xapian::PerlStopper) perl(Search::Xapian::PositionIterator) perl(Search::Xapian::PostingIterator) perl(Search::Xapian::Query) perl(Search::Xapian::QueryParser) perl(Search::Xapian::RSet) perl(Search::Xapian::SimpleStopper) perl(Search::Xapian::Stem) perl(Search::Xapian::Stopper) perl(Search::Xapian::TermGenerator) perl(Search::Xapian::TermIterator) perl(Search::Xapian::TradWeight) perl(Search::Xapian::ValueIterator) perl(Search::Xapian::Weight) perl(Search::Xapian::WritableDatabase) perl(Tie::Array) perl(UNIVERSAL) perl(overload) perl(strict) perl(warnings) rtld(GNU_HASH) + Not a GUI application Suggestions: 1) you can write %files as %doc Changes README %{perl_vendorlib}/* %{_mandir}/man3/* 2) Fix Changelog entry versions in SPEC APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review