Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515032 Bob Relyea <rrelyea@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(rrelyea@xxxxxxxxx | |m) --- Comment #14 from Bob Relyea <rrelyea@xxxxxxxxxx> 2009-08-13 18:03:19 EDT --- 1. URL - points to a generic NSS page. Is there a worry that mozilla may move the actual FTP site around. See http://fedoraproject.org/wiki/Packaging/SourceURL for examples. I believe this tar was pulled for an NSS cvs tag and then the split.sh was ran on it. The wiki has examples for this case (you've partially included the right thing with the comment and conclusing of the nss.split.sh script. 2. You are creating a new empty directory %{libdir}/nss3 is there a reason (if so comment it, if not remove it). 3. the %define nspr-version should technically be %global 4. uncomment the Requires: nss-util in the nss-util-devel package section. 5. This last on is the biggest one: The issue showed up in multiple locations, including rpmlint. In the %build you are creating nss-util.pc and nss-util-config and placing them into the build root. This is a non-standard use of the build root, and requires the first command in %install which clears the buildroot to be removed. A better way would be to create nss-util.pc and nss-util-config in %build and place the results in mozilla/dist (where NSS build results are placed), then install them into their final location in the %include. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review