Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516364 --- Comment #10 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-08-13 13:58:48 EDT --- For -0.1: * _initddir - Well, actually the macro written at the top should be _initddir, not initddir, sorry... -------------------------------------------------------- %{!?_initddir: %global _initddir %{_sysconfdir}/rc.d/init.d} -------------------------------------------------------- * Macros - If you want to use %__install and %__rm, please use %__sed, %__make for consistency (and you also use "rm") * Directory ownership issue - Still the directory %_datadir/xrdp itself is not owned by any packages. * About %_sysconfdir/xrdp/rsakeys.ini: - You have to use %verify(not ....), like: --------------------------------------------------------- %install rm -rf %{buildroot} make install DESTDIR=%{buildroot} .... # rsakeys.ini touch %{buildroot}%{_sysconfdir}/xrdp/rsakeys.ini chmod 06?? %{buildroot}%{_sysconfdir}/xrdp/rsakeys.ini .... %files .... %verify(not size md5 mtime) %{_sysconfdir}/xrdp/rsakeys.ini .... --------------------------------------------------------- * By the way, when I try xrdp-keygen, rsakeys.ini is created with 0600 permission. - If this permission (0600) is correct, %attr(0600,root,root) is also needed. - If the permission should be 0644 or so, %post scriptlet needs fixing. ( I think anyway changing permission on %post explicitly is preferred ) * Currently rsakeys.ini is recreated every time xrdp is upgraded. Is this correct? If not, something like --------------------------------------------------------- [ -s %{_sysconfdir}/xrdp/rsakeys.ini ] || \ xrdp-keygen xrdp %{_sysconfdir}/xrdp/rsakeys.ini >/dev/null chmod 06?? %{_sysconfdir}/xrdp/rsakeys.ini --------------------------------------------------------- is needed so that rsakeys.ini won't be overwritten. ( I used "-s" here, not "-f", because at first install, 0 size rsakeys.ini is installed ) * Note that I think ">/dev/null" is okay, however ">/dev/null 2>&1" should be avoided. If this command outputs some errors, we should check them and examine what was wrong. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review