[Bug 516654] Review Request: gnome-shell - Window management and application launching for GNOME [3]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516654





--- Comment #5 from Josh Boyer <jwboyer@xxxxxxxxx>  2009-08-12 09:13:55 EDT ---
 +:ok, =:needs attention, -:needs fixing

MUST Items:
[=] MUST: rpmlint must be run on every package.

[jwboyer@hansolo ~]$ rpmlint  ~/Download/gnome-shell.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[jwboyer@hansolo ~]$ rpmlint  ~/Download/gnome-shell-2.27.0-3.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[jwboyer@hansolo ~]$ rpmlint  ~/Download/gnome-shell-2.27.0-3.x86_64.rpm 
gnome-shell.x86_64: E: explicit-lib-dependency librsvg2
gnome-shell.x86_64: E: zero-length /usr/share/doc/gnome-shell-2.27.0/README
gnome-shell.x86_64: W: non-conffile-in-etc
/etc/gconf/schemas/gnome-shell.schemas
1 packages and 0 specfiles checked; 2 errors, 1 warnings.


[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.

[jwboyer@hansolo SOURCES]$ sha1sum gnome-shell-2.27.0.tar.bz2 
9bf1f96e4d70505101730579d396cd32e2488bce  gnome-shell-2.27.0.tar.bz2
[jwboyer@hansolo SOURCES]$ wget
http://ftp.gnome.org/pub/GNOME/sources/gnome-shell/2.27/gnome-shell-2.27.0.tar.bz2
--2009-08-12 08:55:24-- 
http://ftp.gnome.org/pub/GNOME/sources/gnome-shell/2.27/gnome-shell-2.27.0.tar.bz2
Resolving ftp.gnome.org... 130.239.18.173, 130.239.18.137,
2001:6b0:e:2018::173, ...
Connecting to ftp.gnome.org|130.239.18.173|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 437202 (427K) [application/x-bzip2]
Saving to: `gnome-shell-2.27.0.tar.bz2.1'

100%[=====================================>] 437,202      271K/s   in 1.6s    

2009-08-12 08:55:27 (271 KB/s) - `gnome-shell-2.27.0.tar.bz2.1' saved
[437202/437202]

[jwboyer@hansolo SOURCES]$ sha1sum gnome-shell-2.27.0.tar.bz2.1 
9bf1f96e4d70505101730579d396cd32e2488bce  gnome-shell-2.27.0.tar.bz2.1

[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[+] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.
[-] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissible content. This is
described in detail in the code vs. content section of Packaging Guidelines.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[=] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1600644

So there are a couple of small items to fixup:

1) Fix the rpmlint output
2) I think the package should own %{_datadir}/gnome-shell and
%{_libdir}/gnome-shell
3) You probably need Requires: GConf2 for the usage in %pre/%postun
4) You don't actually call dekstop-file-install in the %install section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]