Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516906 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2009-08-12 03:23:47 EDT --- Hello Johan, since this seems to be your first review request and I can't find you in the Fedora account system, you need a sponsor reviewing this package. To find one, add the FE-NEEDSPONSOR tag in the Blocks field above. For further information see http://fedoraproject.org/wiki/PackageMaintainers/Join#Create_Your_Review_Request I just had a quick look at your spec file and noticed a couple of things to fix: - please remove the leading header comment - the License tag should probably be LGPLv2+ (see the license abbreviation page) - fix the Source tags according to http://fedoraproject.org/wiki/Packaging:SourceURL - remove "python" from Requires, as it's determined automatically - you probably don't need to add the autotools to BuildRequires - add a %changelog section at the bottom of the spec file showing the revision history $ rpm -qlp frepple-0.7.1-1.fc12.src.rpm frepple-0.7.1.spec frepple-0.7.1.tar.gz The spec filename must be frepple.spec (remove the version number). $ rpmlint frepple-0.7.1-1.fc12.src.rpm frepple.src: E: no-changelogname-tag frepple.src: W: invalid-license LGPL, v2.1 frepple.src: W: invalid-license greater frepple.src: E: invalid-spec-name 1 packages and 0 specfiles checked; 2 errors, 2 warnings. Again, the complete review must be done by a sponsor. :) Martin -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review