Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jussi.lehtola@xxxxxx Flag| |fedora-review? --- Comment #25 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-08-11 10:52:12 EDT --- Good, now the package builds in mock. There are still a few issues to fix: rpmlint reports: sys_basher.src: E: description-line-too-long low level functions including memory bandwidth (at all levels of the hierarchy), sys_basher.src: E: description-line-too-long disk IO bandwidth and integer and floating point operations using unrolled loops. sys_basher.src: W: strange-permission sys_basher.spec 0770 sys_basher.x86_64: E: description-line-too-long low level functions including memory bandwidth (at all levels of the hierarchy), sys_basher.x86_64: E: description-line-too-long disk IO bandwidth and integer and floating point operations using unrolled loops. sys_basher.x86_64: E: non-standard-executable-perm /usr/bin/sys_basher 0775 3 packages and 0 specfiles checked; 5 errors, 1 warnings. To fix these you need to break the description to less than 80 character lines, e.g. sys_basher is a multithreaded system exerciser. It tests the CPU, RAM and Disks under conditions of maximum stress by running CPU, Memory and Disk tests on all Cores simultaneously. In addition to reliablity testing, sys_basher benchmarks low level functions including memory bandwidth (at all levels of the hierarchy), disk IO bandwidth and integer and floating point operations using unrolled loops. ** Change the spec file permission to 0644 (the one you build the srpm from). ** To fix the executable perm issue you can either run chmod 755 $RPM_BUILD_ROOT%{_bindir}/sys_basher or modify the upstream makefile which should use install instead of 'mv': Add the definition INSTALL="install -p" to the top of the makefile and change the install target to install: sys_basher ${INSTALL} -D -m 755 sys_basher ${DESTDIR}/sys_basher This command will automatically create ${DESTDIR} if it does not exist, and copy the executable with 755 permissions. ** After these changes the package should be in order. Then you need to perform the informal reviews to show me that you know the Fedora guidelines as per comment #2. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review