Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516466 --- Comment #18 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-08-11 01:51:29 EDT --- As instructed in comment #6 and comment #13, please paste new SPEC & SRPM urls in the review whenever you have updated something. ** The package *STILL DOES NOT COMPILE* In file included from sys_main.c:28: sys_basher.h:37:21: error: ncurses.h: No such file or directory In file included from sys_basher.h:49, from sys_main.c:28: sys_curses.h:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token sys_curses.h:30: error: expected ')' before '*' token sys_curses.h:31: error: expected ')' before '*' token In file included from sys_disk.c:28: sys_basher.h:37:21: error: ncurses.h: No such file or directory In file included from sys_utils.c:28: sys_basher.h:37:21: error: ncurses.h: No such file or directory In file included from sys_basher.h:49, from sys_disk.c:28: sys_curses.h:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token sys_curses.h:30: error: expected ')' before '*' token sys_curses.h:31: error: expected ')' before '*' tokenIn file included from sys_basher.h:49, from sys_utils.c:28: sys_curses.h:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token sys_curses.h:30: error: expected ')' before '*' token sys_curses.h:31: error: expected ')' before '*' token make: *** [sys_main.o] Error 1 make: *** Waiting for unfinished jobs.... In file included from sys_kernel.c:28: sys_basher.h:37:21: error: ncurses.h: No such file or directory make: *** [sys_disk.o] Error 1 In file included from sys_basher.h:49, from sys_kernel.c:28: sys_curses.h:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token sys_curses.h:30: error: expected ')' before '*' token sys_curses.h:31: error: expected ')' before '*' token make: *** [sys_kernel.o] Error 1 make: *** [sys_utils.o] Error 1 If you need ncurses, add BuildRequires: ncurses-devel as instructed in comment #2. ** Makefile, COPYRIGHT and README in the upstream tarball *STILL* have executable flags. Remove them from the upstream release, or remove them in the %prep phase. ** You are missing the -2 release from the changelog. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review