Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: picocom - Minimal serial communications program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206395 ------- Additional Comments From denis@xxxxxxxxxxxxx 2006-09-14 07:25 EST ------- Looks good! Must fix: - debug package is broken. Just remove the strip command from the spec and let RPM handle it automatically. - RPM_OPT_FLAGS and compiler string are not honored. For example, just add 'CC=%{__cc} CFLAGS="$RPM_OPT_FLAGS" to the make command. Also add '%{_smp_mflags}' to make line. - in %files section, use %{_bindir} instead of /usr/bin/ - don't include empty TODO file. Nice to have: - use install instead of cp, to make sure files get correct permissions -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review