Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506825 --- Comment #6 from Christoph Wickert <christoph.wickert@xxxxxxxxxxxxxx> 2009-08-08 11:59:03 EDT --- REVIEW FOR 2aecdc6fffa19a097537cca3b8a775e7 bickley-0.4.3-3.fc11.src.rpm OK - MUST: rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/bickley-* bickley.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/bkl-orbiter.schemas bickley-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 2 warnings. (gconf schemas are no config files as they are not expected to be edited) OK - MUST: named according to the Package Naming Guidelines OK - MUST: spec file name matches the base package %{name} OK - MUST: package meets the Packaging Guidelines OK - MUST: Fedora approved license and meets the Licensing Guidelines: LGPLv2.1 ??? - MUST: License field in spec does not match the actual license: GPLv2 vs. LGPLv2 OK - MUST: license file included in %doc OK - MUST: spec is in American English OK - MUST: spec is legible OK - MUST: sources match the upstream source by MD5 0154c4813294c4fe76690795c7efd8ac OK - MUST: successfully compiles and builds into binary rpms on all primary arches OK - MUST: all build dependencies are listed in BuildRequires. N/A - MUST: handles locales properly with %find_lang OK - MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. OK - MUST: not relocatable OK - MUST: owns all directories that it creates OK - MUST: no duplicate files in the %files listing OK - MUST: permissions on files are set properly, includes %defattr(...) OK - MUST: package has a %clean section, which contains rm -rf %{buildroot}. OK - MUST: consistently uses macros OK - MUST: package contains code N/A - MUST: Large documentation files should go in a -doc subpackage OK - MUST: Files included as %doc do not affect the runtime of the application OK - MUST: Header files are in a -devel package N/A - MUST: Static libraries must be in a -static package OK - MUST: - devel package 'Requires: pkgconfig'. OK - MUST: library files that end in .so (without suffix) are in -devel package. OK - MUST: -devel package requires base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} OK - MUST: The package does not contain any .la libtool archives. OK - MUST: No GUI app, no desktop file. OK - MUST: packages does not own files or directories already owned by other packages. OK - MUST: at the beginning of %install, the package runs rm -rf %{buildroot}. OK - MUST: all filenames valid UTF-8 SHOULD Items: OK - SHOULD: Source package includes license text(s) as a separate file. N/A - SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. OK - SHOULD: The the package builds in mock. OK - SHOULD: The package should compile and build into binary rpms on all supported architectures. OK - SHOULD: functions as described. FIX - SHOULD: If scriptlets are used, those scriptlets must be sane. N/A - SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. OK - SHOULD: pkgconfig(.pc) files are in -devel pkg. N/A - SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. Other items: OK - latest stable version packaged OK - proper debuginfo package OK - compiler flags honored OK - timstamps preserved during install Issues: - Missing Requirements: Requrires: dbus (only dbus-libs will be pulled in but not) Requires(pre): GConf2 Requires(post): GConf2 Requires(post): /sbin/ldconfig Requires(preun): GConf2 see https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf - devel package Requires: gtk-doc, but I see no gtk doc files - %configure with -disable-schemas to avoid this build related error: /bin/sh: --makefile-install-rule: command not found Warning: No permission to install schema files, install manually add - %configure with --disable-rpath instead of the seed hack (tested and works) - License is unclear. Spec: GPLv2+, COPYING is GPLv2 but the headers of the sources are LGPLv2. This looks like a mistake to me. Please ask upstream for clarification. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review