Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516059 --- Comment #2 from Andrew Colin Kissa <andrew@xxxxxxxxxxxxx> 2009-08-07 15:21:15 EDT --- Hi Steve, If you are a packager you can do a full review of packages, except those that require sponsorship. Issues raised: 1. I do not agree, i have not come across and fedora guidelines forbidding creating files from with in the spec file. Take a look at http://fedoraproject.org/wiki/Packaging/Guidelines#.desktop_file_creation which indicates you can create the file from with in the spec. Anyway i would prefer to maintain one file as opposed to maintaining multiple files. 2. Fixed. This seems to be a grey area the other packages i have seen use condrestart but i agree graceful is a better way to go. 3. I have moved them to %prep instead i think that is the most appropriate place for them. 4. Unfortunately i cannot fix this due to the sed lines, but this is not a blocker. Updated spec and srpm http://topdog-software.com/oss/SRPMS/fedora/dokuwiki/dokuwiki.spec http://topdog-software.com/oss/SRPMS/fedora/dokuwiki/dokuwiki-0-0.2.20090214.b.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review