Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512627 --- Comment #3 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-08-07 14:21:55 EDT --- - I suggest versioning the java BR and R as for the other packages. - Fix the .jar and .class clean operation, either find \( -name '*.jar' -o -name '*.class' \) -exec rm -f '{}' \; or find -name '*.jar' -exec rm -f '{}' \; find -name '*.class' -exec rm -f '{}' \; - This is silly (doesn't end up in the package anyway): chmod +x %{name}.sh drop it. Also use install -D -p -m 755 %{name}.sh %{buildroot}%{_bindir}/%{name} so you can drop the chmod line altogether. - Again, you are versioning the jars when upstream doesn't use versioned jars. You should drop the versioning altogether as it serves no purpose. - Don't use wildcards in %files when they're not needed, use %{_javadir}/%{name}.jar %{_javadir}/%{name}-%{version}.jar - Categories=Application is obsolete, drop it from the .desktop file. Drop GTK too. And remove the empty line at the top of the .desktop file. ** rpmlint output is clean. MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. OK - You could add -p to the javadoc cp section, but javadoc is anyway created from the sources. MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. N/A MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. N/A MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK MUST: Desktop files are installed properly. OK MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK ** Fix the issues at the top of the comment and I'll approve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review