Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=514833 --- Comment #3 from Andrew Colin Kissa <andrew@xxxxxxxxxxxxx> 2009-08-07 10:37:04 EDT --- Some notes: * Language API's - As per the package description you need to ship the Search API's with the package, as suggested before i think you should ship libsphinxclient as subpackages (lib and devel) since it is a library The other languages (PHP,Python,Ruby,Java) can be shipped within the main package * * Macros consistency - Well, if you want to use %{__mkdir} or %{__cp} style, please use %{__make}, %{__rm}, %{__sed}, etc for consistency. * Timestamps - Would you consider using --------------------------------------------------------------- make install DESTDIR=%{buildroot} INSTALL="install -p" install -p -D -m 0755 %{SOURCE1} $RPM_BUILD_ROOT%{_initrddir}/%{name} --------------------------------------------------------------- for example to keep timestamps on installed files? http://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review