Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506833 --- Comment #9 from Peter Robinson <pbrobinson@xxxxxxxxx> 2009-08-07 06:09:28 EDT --- > > I've needed it for gtk based apps in the past, that's why I added it. I will > > investigate it tomorrow. > > gnome-common can be dropped, I tested it. intltool and gettext are needed for > the locales, so the only thing left for autogen.sh is libtool. Just move the > comment down by three lines and it's correct. Done > OK - SHOULD: The package functions as described. However I noticed a small > annoyance: When hovering the close button in the top right corner, I get the > gtk-broken icon, although I have moblin-icon-theme-installed. Can you confirm > this? If so, I will look into that That might be fixed in the upstream icon theme. I will add it to my check list for the weekend. I'm hoping to have a test spin to play with then. > Issues: > "INSTALL='install -p'" belongs to make install, not to make! Should be > make install DESTDIR=%{buildroot} INSTALL='install -p' Oops. That will teach me to make changes at 1am :) Fixed. > The summary still is "Moblin web services settings", you might want to change > that to to make Jeff happy. How's "Moblin configuration tool for mojito social network aggregator" > Please fix the remaining issues. None of these are real blockers, so the > package is APPROVED. For reference changes are in spec and here: http://pbrobinson.fedorapeople.org/bisho-0.10.7-3.fc11.src.rpm Thanks :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review