Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505813 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx --- Comment #1 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-08-06 09:05:08 EDT --- A few notes: - The license of GSL, FFTW &c does not affect the license tag (Fedora policy). License should be lgpl. - Drop the explicit Requires, they're automatically picked up by rpm. http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires - You can only define subpackages BuildArch: noarch on >= F11 and >= RHEL6. - You can change find ./data/ -name \*.data -exec chmod 644 {} \; chmod 644 ./data/structures/test.btf chmod 644 ./source/STRUCTURE/smartsParserParser.y chmod 644 ./source/STRUCTURE/smartsParserLexer.l find ./ -name \*.h -executable -exec chmod 644 {} \; find ./ -name \*.C -executable -exec chmod 644 {} \; to find data/ -name \*.data -exec chmod 644 {} \; chmod 644 data/structures/test.btf \ source/STRUCTURE/smartsParserParser.y \ source/STRUCTURE/smartsParserLexer.l find . -name \*.h -executable -exec chmod 644 {} \; find . -name \*.C -executable -exec chmod 644 {} \; - Change BuildRequires: qt-devel to BuildRequires: qt4-devel to get qt4. - Why do you remove header documentation? You could place them in the -doc package. - Don't add an soversion yourself. This has to be done by upstream. - Drop #Install documentation mkdir -p %{buildroot}%{_docdir}/%{name} cp -Rp ./doc/BALLView %{buildroot}%{_docdir}/%{name} cp -Rp ./doc/doxygen %{buildroot}%{_docdir}/%{name}/doxygen instead list these in the %doc of -doc. - Instead of /%{_libdir}/libBALL.so.* use %{_libdir}/libBALL.so.* as %{_libdir} starts with a /. Same thing with other directories. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review