Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504424 --- Comment #10 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-08-05 14:06:33 EDT --- For 1.1.7-2: * URL - Would you explain why you prefer to use http://rubyforge.org/frs/download.php/... instead of the URL I wrote in my previous comment (note that the repoid "59617" changes randomly every time the version is upgraded) ? Non-gem support - It is okay to add non-gem support, however would you explain why you want to add this for json (while ruby-json is not in Fedora yet)? ( And perhaps * Installation directory under %_builddir ----------------------------------------------------------- pushd ./%{gemdir} gem install --local --install-dir ./%{gemdir} -V --force %{SOURCE0} ----------------------------------------------------------- - So gem file is installed under %_builddir/%{name}-%{version}/%{gemdir}/%{gemdir}, which should be %_builddir/%{name}-%{version}/%{gemdir} ( The first line of "pushd" is not needed ) * gem script files under bin/ ----------------------------------------------------------- mv $RPM_BUILD_ROOT/%{gemdir}/bin/* $RPM_BUILD_ROOT/%{geminstdir}/bin ----------------------------------------------------------- - Well, actually the scripts under %gemdir/bin and under %geminstdir/bin are different and both scripts are needed. The scripts under %{gemdir}/bin load the file under %{geminstdir}/bin. While we usually move the scripts under %{gemdir}/bin to %{_bindir} like: ----------------------------------------------------------- mkdir %{buildroot}%{_bindir} mv %{buildroot}%{gemdir}/bin/* %{buildroot}%{_bindir} rmdir %{buildroot}%{gemdir} ----------------------------------------------------------- the scripts under %{geminstdir}/bin should not be modified (except for shebang issues or so) * %check - The reason %check fails for you is that you are trying to do "rake --test" under %{buildroot}%{geminstdir}, where some files needed for tests (like ext/) are already cleaned up. The correct way is to call "rake --test" under %_builddir/%name-%version/%{geminstdir}. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review