[Bug 513119] Review Request: PgsLookAndFeel - Nice looking LookAndFeel for Swing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513119


Jussi Lehtola <jussi.lehtola@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #9 from Jussi Lehtola <jussi.lehtola@xxxxxx>  2009-08-05 12:39:21 EDT ---
You might want to use a fully versioned dependency,
 Requires: %{name} = %{version}-%{release}

**

I'd change
 %{_javadir}/*
to
 %{_javadir}/%{name}*.jar

Actually,
 http://fedoraproject.org/wiki/Packaging/Java#Jar_file_naming
states that
 "If the package provides several JAR files, the filenames assigned by the
build 
 must be used"
so I think you shouldn't add the version suffix to the jar files.

**

You need to run
 find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;
in %prep to remove any pre-existing jar and class files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]