Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515107 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-08-04 21:08:41 EDT --- And yet another cookie-cutter review. As I always build in rawhide I don't see the above failure. The only interesting thing here is the huge dependency list sucked in by graphviz. That package could really use a split. * source files match upstream. sha256sum: 4a1fa7c96d655073bc48f893980a8290414ecdd69c91d792136e3a389eff3033 DBIx-Class-TimeStamp-0.12.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(DBIx::Class::TimeStamp) = 0.12 perl-DBIx-Class-TimeStamp = 0.12-1.fc12 = perl(:MODULE_COMPAT_5.10.0) perl(DBIx::Class) perl(DBIx::Class::DynamicDefault) perl(DateTime) perl(base) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=7, Tests=22, 4 wallclock secs ( 0.03 usr 0.02 sys + 1.47 cusr 0.18 csys = 1.70 CPU) Result: PASS * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review