Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: yafc: yet another ftp client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192606 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-09-12 22:11 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 832d074183a36ee15b47553ed5962fce yafc-1.1.1.tar.bz2 832d074183a36ee15b47553ed5962fce yafc-1.1.1.tar.bz2.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. See below - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package doesn't own any directories other packages own. OK - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. OK - Should build in mock. Issues: 1. You might change your default attributes from: %defattr(-, root, root) to %defattr(-, root, root,-) Aside from that I see no issues. Feel free to change issue #1 above when you check the package in. Pending that, this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review