Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515164 Chess Griffin <chess@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chess@xxxxxxxxxxxxxxxx --- Comment #1 from Chess Griffin <chess@xxxxxxxxxxxxxxxx> 2009-08-04 15:05:40 EDT --- I think before anyone can give you a more detailed review, there are some things you should address and fix. As an initial point, you should run rpmlint with -vi switch to give you more information. Since this is a Python application, you may want to read the Python packaging wikipage (http://fedoraproject.org/wiki/Packaging:Python). It also appears you do not use the Makefile that is included with the source and it looks like the Makefile supports DESTDIR, PREFIX etc. Why do you not use it? Specifc comments are below: > gnomenu.src: W: non-standard-group Graphical desktop/GNOME As the message says, you have a non-standard group. Run "less /usr/share/doc/rpm-*/GROUPS" to get a list. I would also check similar packages in Fedora and see what groups they use. > gnomenu.noarch: E: explicit-lib-dependency python-xlib Add python-xlib as a BuildRequires. > gnomenu.src:49: E: hardcoded-library-path in /usr/lib/gnomenu/GnoMenu.py You have a hardcoded path in your spec file (line 49). You should use macros instead (http://fedoraproject.org/wiki/Packaging/RPMMacros). If hardcoded paths are in the source, (and I think they are in the Makefile, for example) you may need to figure out a way to fix that if you can, either by overriding it if possible or using an inline sed or patch. Patches should be sent upstream. > gnomenu.src:62: W: libdir-macro-in-noarch-package (main package) > %{_libdir}/bonobo/servers/*.server > gnomenu.src:63: W: libdir-macro-in-noarch-package (main package) > %{_libdir}/%{name}/* Following on with the previous comment, double-check whether this really is a noarch package. I believe the Python packaging page linked to above has information on multilib installations. > gnomenu.noarch: E: script-without-shebang > /usr/lib/gnomenu/locale/Settings_LangPack_en.xml ... All of these "script without shebang" messages are explained here: http://fedoraproject.org/wiki/Common_Rpmlint_issues#script-without-shebang Perhaps these xml files have an executible bit set when it is not needed. If so, you may need to remove that. > gnomenu.noarch: W: non-conffile-in-etc /etc/gnomenu/prefix Configuration files often need to be handled with %config(noreplace) as mentioned here: http://fedoraproject.org/wiki/Packaging/Guidelines#Configuration_files > gnomenu.noarch: W: hidden-file-or-dir /usr/share/gnomenu/Themes/Menu/Short/.png ... > gnomenu.noarch: W: hidden-file-or-dir /usr/share/gnomenu/Themes/Icon/BW/.png Are these two files just cruft left over in the source? If so, should they be deleted before cleaning RPM_BUILD_ROOT? HTH -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review