Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Thunar - Thunar File Manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205912 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2006-09-12 16:21 EST ------- (In reply to comment #2) > ok, added: > BuildRequires: freetype-devel > BuildRequires: pkgconfig > BuildRequires: libxslt-devel This seems wrong to me, since what is required is the xsltproc program, which is in libxslt. > BuildRequires: GConf2-devel > BuildRequires: gtk-doc > > I'll take a look at not building the trash panel applet. It is automatically not built with the xfce-panel in -devel, so it is allready not built, however it is in %files... > I'll look at the xfce4-dev-tools, but I would expect them to fix things so > thats not required for the final release, since that package is supposed to > only be needed for developers. It is not required at all for this release. However I consider it a good thing when all the packages required for developers are there, even they are not needed at all (as buildrequires or requires) in the normal cases. Indeed, it may be usefull in case somebody want to modify the tarball itself, regenerate configure file, do tests, regenerate documentation and so on. Not a blocker, just a suggestion. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review