Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515143 --- Comment #6 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2009-08-03 07:35:46 EDT --- I just found some more issues - seems, that these are the last remaining issues: * You don't need to explicitly add "Requires: perl-Some-Extension" since rpmbuild can find them automatically (it scans sources for "use Some::Thing" directives and for shebangs, and adds them as "Requires: perl(Some::Thing). So, I advise you to remove all explicit Requires directives. * No need to add perl as BuildRequires. * Please, don't mark man-files ad %doc, e.g. remove %doc directive before %{_mandir}/man1/*.* in the %files section. * Blocker issue. You must add "rm -rf $RPM_BUILD_ROOT" to the head of your install section. * I advice you to shorten %install section by exploiting the magic power of "install" utility - it can create necessary directories by user's demand, while installing. E.g. instead of install -d $RPM_BUILD_ROOT%{_bindir} install mtkbabel $RPM_BUILD_ROOT%{_bindir}/ install -d $RPM_BUILD_ROOT%{_mandir}/man1 install -m0644 mtkbabel.1 $RPM_BUILD_ROOT%{_mandir}/man1/ you may simply write (note -D switch added): install -D -m 0755 mtkbabel $RPM_BUILD_ROOT%{_bindir}/mtkbabel install -D -m 0644 mtkbabel.1 $RPM_BUILD_ROOT%{_mandir}/man1/mtkbabel.1 I'm sorry, for not to pointing you to all these issues before - seems that I looked to your first srpm very inattentively. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review