Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515040 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Kevin Fenzi <kevin@xxxxxxxxx> 2009-08-01 16:44:10 EDT --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 891a85984bb44b12431f5998a05fe2ff iXhash-1.5.5.tgz 891a85984bb44b12431f5998a05fe2ff iXhash-1.5.5.tgz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: spamassassin-plugin-ixhash.noarch: W: summary-not-capitalized iXhash fuzzy network hash plugin for spamassassin spamassassin-plugin-ixhash.src: W: summary-not-capitalized iXhash fuzzy network hash plugin for spamassassin Can be ignored, but iXhash doesn't mean much to most people I suspect. You could just drop that and cap the F in fuzzy? spamassassin-plugin-ixhash.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/spamassassin-plugin-ixhash-1.5.5/CHANGELOG spamassassin-plugin-ixhash.noarch: W: file-not-utf8 /usr/share/doc/spamassassin-plugin-ixhash-1.5.5/CHANGELOG Suggest: dos2unix them? Not a big deal, but easy to do. None of those are blockers, so this package is APPROVED. Please look at tweaking those on import. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review