Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513797 Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(fedora@christoph- | |wickert.de) | --- Comment #8 from Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx> 2009-07-31 06:13:15 EDT --- (In reply to comment #7) > Line 298/299 is not part of the license, but merely an example of how to > include GPLv2(+) in your programs. As most people choose to literally take the > text (which is not a bad idea), this text can usually be found in headers > and/or source files. I told Soeren that I would prefer a license block in the headers, but he did not change that in the last two releases. Obviously not everybody cares about licensing as much as we do. > NOT OK: I agree that you need libgnomeui-devel, but libgnomeui-devel gets > pulled in by gnome-panel-devel. Again, as per > http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires, it should > be removed. You are confusing Requires and BuildRequres here. rpm has a dependency generator for Requires, but not for BuildRequires. > We implicitly agreed on this during the review of > gnome-applet-bubblemon (bug 497525): No, we agreed on leaving gettext in although it's already pulled in by intltool. That's just like gnome-panel-devel and libgnomeui-devel, but I can remove it if you insist on doing so. > NOT OK: I'm sorry the comment appears to be unclear. I know you depend on > gnome-panel-devel, but why did you state version >= 2.6. This requirement on > the version is not documented in the tarball, and AFAICS, is not checked by the > configure script. This is correct, configure does not check for the version properly. This information also is from upstream. > If you indeed require >= 2.6, then this version is also 'very > old'. Fedora 7 included 2.18.3-1. As per > http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires, you > should drop te version requirement. Again, these are BuildRequires. I want to make live easier for people who are rebuilding our packages - even on ancient distros if they want. > Open issues: > - superfluous dependency on libgnomeui-devel in BuildRequires > - versioned dependency on gnome-panel-devel >= 2.6 in BuildRequires explained above > - contact the upstream author to see if he would include the text and actions > as mentioned in GPLv2 (lines 282-311) in the next release I did twice, but no avail. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review