Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513797 Edwin ten Brink <fedora@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC|fedora@xxxxxxxxxxxxxxxxxxx | Flag| |needinfo?(fedora@christoph- | |wickert.de) --- Comment #5 from Edwin ten Brink <fedora@xxxxxxxxxxxxxxxxxxx> 2009-07-30 17:39:50 EDT --- Formal review for gnome-applet-cpufire-1.6-1 -------------------------------------------- MUST Items Items marked as MUST are things that the package (or reviewer) MUST do. If a package fails a MUST item, that is considered a blocker. No package with blockers can be approved on a review. Those items must be fixed before approval can be given.* MUST: rpmlint must be run on every package. The output should be posted in the review. * MUST: The package must be named according to the Package Naming Guidelines. + OK * MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. + OK * MUST: The package must meet the Packaging Guidelines. + OK * MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. + OK. The package comes with GNU GENERAL PUBLIC LICENSE Version 2, June 1991. * MUST: The License field in the package spec file must match the actual license. - NOT OK: The package comes with GNU GENERAL PUBLIC LICENSE Version 2, June 1991. There appears to be no reference to GPLv2+ which is in the spec file. * MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. + OK * MUST: The spec file must be written in American English. + OK * MUST: The spec file for the package MUST be legible. + OK * MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. + OK + $ md5sum -b cpufire_applet-1.6.tar.gz ../../Download/cpufire_applet-1.6.tar.gz + 5837d2abf7eabd1e4985817efccf4bb4 *cpufire_applet-1.6.tar.gz + 5837d2abf7eabd1e4985817efccf4bb4 *../../Download/cpufire_applet-1.6.tar.gz * MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. + OK * MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. + N/A * MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines; inclusion of those as BuildRequires is optional. Apply common sense. - libgnomeui-devel gets pulled in by gnome-panel-devel, I would list that in a comment and comment out the BR libgnomeui-devel - Why is the BR GConf2 commented out? Either remove it, or add a comment to state the reason (gets pulled in by gnome-panel-devel, which requires libgconf). ? Why do you need gnome-panel-devel >= 2.6? The reason for this seems not documented in the source tarball. * MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. + OK * MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. + N/A * MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. + N/A (not relocatable) * MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. - NOT OK: Package does not own %{_datadir}/omf/cpufire/, but only contained files via %{_datadir}/omf/cpufire/cpufire-*.omf * MUST: A Fedora package must not list a file more than once in the spec file's %files listings. + OK * MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. + OK * MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + OK * MUST: Each package must consistently use macros. + OK * MUST: The package must contain code, or permissible content. + OK * MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). + N/A * MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. + OK ? You did not include the empty files MAINTAINERS, NEWS and TODO. If these are added in the next release, you'll have to adapt your spec file. It may be wise to incorporate these empty files to prevent the hassle later. * MUST: Header files must be in a -devel package. + N/A * MUST: Static libraries must be in a -static package. + N/A * MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). + N/A * MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. + N/A * MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} + N/A * MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. + N/A * MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. + N/A (a desktop applet does not require .desktop file) * MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. + OK * MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + OK * MUST: All filenames in rpm packages must be valid UTF-8. + OK SHOULD Items: Items marked as SHOULD are things that the package (or reviewer) SHOULD do, but is not required to do. * SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. + OK (file COPYING is included) * SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. + N/A * SHOULD: The reviewer should test that the package builds in mock. + Builds under Fedora 11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1567422 + Builds under Fedora rawhide (F12): http://koji.fedoraproject.org/koji/taskinfo?taskID=1567452 * SHOULD: The package should compile and build into binary rpms on all supported architectures. + OK * SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. + OK * SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. + OK (according to https://fedoraproject.org/wiki/Packaging:ScriptletSnippets) * SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. + N/A * SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. + N/A * SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. + N/A In summary: - rpmlint warning to be fixed - license does not seem to match - comment out libgnomeui-devel in BuildRequires including comment as to why - either add comment to, or remove BR GConf2 commented out - explain why you need gnome-panel-devel >= 2.6 - own %{_datadir}/omf/cpufire/ - optionally: include the empty files MAINTAINERS, NEWS and TODO -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review