Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505374 --- Comment #14 from Eric Sandeen <esandeen@xxxxxxxxxx> 2009-07-30 14:52:46 EDT --- (In reply to comment #13) > Patch0 needs a comment. ok. upstream is fixing this (and the ldconfig problem) so it'll be dropped soon. > You should use %global instead of %define, and preferably move the _root_libdir > definition to the top of the spec file. For consistency I suggest defining also > a macro for /sbin. ok 4 packages and 0 specfiles checked; 1 errors, 1 warnings. > > Uncomment the rm command in %clean. argh debugging leftovers. > > Fix the issues before importing to cvs. The package has been > > APPROVED Thanks! And thanks for your patience - Sorry it was so iterative, I guess I'm just not very good at this ;) -Eric -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review