[Bug 196847] Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-PHPUnit2 - PEAR: Regression testing framework for unit tests
Alias: php-pear-PHPUnit2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196847


tibbs@xxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs@xxxxxxxxxxx  2006-09-11 15:25 EST -------
I'm going to go ahead and approve this.  If you want to update to the alpha
version, or someone else wants to approve the -alpha package, then that's fine
with me.

* source files match upstream:
   95fe5e8dbb36462dd4d3f3daf8a4e8b3  PHPUnit2-2.3.6.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text is included in each source file.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent (except for the bogus warning)
* final provides and requires are sane:
   php-pear(PHPUnit2) = 2.3.6
   php-pear-PHPUnit2 = 2.3.6-1.fc6
  =
   /bin/sh
   /usr/bin/pear
   /usr/bin/php
   php >= 5.0.2
   php-pear(Benchmark)
   php-pear(Log)
   php-pear(PEAR)
   php-pecl(Xdebug)
* %check is not present; not possible to run the test suite.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]