Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513191 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-07-29 18:47:16 EDT --- Builds fine and rpmlint is silent. This is not a PECL package, so the naming is correct. Your macro usage is not correct; use either %{buildroot} or $RPM_BUILD_ROOT as you wish, but don't use both. That's the only issue I see, and it's minor, so I'll go ahead and approve this and you can go ahead and fix up the spec when you import the package. * source files match upstream. sha256sum: a0173c785c29bbebdd82f223a27c6682cec4791920c9cabc3ca6f5fd174eb8b0 facedetect-1.0.0.tar.gz * package meets naming and versioning guidelines. X specfile does not use macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: config(php-facedetect) = 1.0.0-1.fc12 facedetect.so()(64bit) php-facedetect = 1.0.0-1.fc12 php-facedetect(x86-64) = 1.0.0-1.fc12 = config(php-facedetect) = 1.0.0-1.fc12 libcv.so.2()(64bit) libcvaux.so.2()(64bit) libcxcore.so.2()(64bit) libhighgui.so.2()(64bit) php(api) = 20090626 php(zend-abi) = 20090626 * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review