Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510743 Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn@xxxxxxxxxxxxxxxxxxxx --- Comment #3 from Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> 2009-07-28 18:52:11 EDT --- I'm not qualified to do a review but here are some informal comments: 1: The link to the source RPM is broken so I can only comment on the spec file. 2: Don't you think the package name should be "ARAnyM" rather than "aranym"? The Naming Guidelines say: «If they refer to their application as "ORBit", you should use "ORBit" as the package name, and not "orbit".» (https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Case_Sensitivity) The website of the project seems to use "ARAnyM" consistently. 3: There is (according to the spec) a patch called "aranym-0.9.8beta.diff". Such a name makes me wonder "differences between aranym-0.9.8beta and what?" It looks like it might contain the changes from (for example) 0.9.0 to 0.9.8beta, but I suppose that's not what it is because the source is already version 0.9.8beta. I think a patch name should say something about what the patch does. Alternatively, a comment might help. 4: I think you forgot to run RPMlint: aranym.spec: E: no-cleaning-of-buildroot %install This is caused by a typo. Please fix. aranym.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 52) Please replace the tabs with spaces. They serve no purpose and can make the file look ugly in other people's editors. (RPMlint also says: aranym.spec:62: W: configure-without-libdir-spec aranym.spec:69: W: configure-without-libdir-spec aranym.spec:73: W: configure-without-libdir-spec I can't really comment on that as I can't see the configure script.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review