Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491980 --- Comment #18 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> 2009-07-28 15:00:56 EDT --- Review: + package builds + rpmlint is silent for SRPM and for RPM. + source files match upstream url $ sha1sum SOURCES/bauble-0.9.2.tar.bz2 c733a41e6654e4107e404ff8911745ea70f316e3 SOURCES/bauble-0.9.2.tar.bz2 $ sha1sum bauble-0.9.2.tar.bz2 c733a41e6654e4107e404ff8911745ea70f316e3 bauble-0.9.2.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. ! BuildRequires are proper. (see below) + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package bauble-0.8.6-2.fc11.noarch => Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires: /usr/bin/env /usr/bin/python python(abi) = 2.6 + GUI App + Desktop file present and installed according to the guidelines My only problem is to make it working. I start it, it asks to create a new connection, I create one named test, I check the box "Use default filename" in SQLite, it says "The database you have connected to is empty" and crashes with this error: $ bauble connmgr.py(633): KeyError: 'default' WARNING: EmptyDatabaseError pluginmgr.py(529): Could not import the bauble.plugins.picasa module. No module named gdata.photos.service [pierrey@red rpmbuild]$ bauble WARNING: EmptyDatabaseError pluginmgr.py(529): Could not import the bauble.plugins.picasa module. No module named gdata.photos.service Any idea ? Also when I click on 'Browse' to select a file to connect to, the cancel button crash with this error: connmgr.py(633): KeyError: 'default' /usr/lib/python2.6/site-packages/bauble/connmgr.py:642: GtkWarning: gdk_x11_atom_to_xatom_for_display: assertion `atom != GDK_NONE' failed r = d.run() Traceback (most recent call last): File "/usr/lib/python2.6/site-packages/bauble/connmgr.py", line 643, in on_activate_browse_button self.file_entry.set_text(d.get_filename()) TypeError: GtkEntry.set_text() argument 1 must be string, not None I think some patch are still needed :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review